[PATCH] D68146: [tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj).

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

Thanks for adding the new option `--ignore-case`. This will be very useful, though it is not clear from the option name that it uses a lowercase pattern:

  size_t Pos = IgnoreCase ? Buffer.find_lower(FixedStr)
                          : Buffer.find(FixedStr);

To make it really `--ignore-case`, the pattern should also be changed to lowercase. It may be worth splitting the patch into two

1. `[FileCheck] Add --ignore-case ...` and add tests to `test/FileCheck/`
2. Fix `od` tests with the new FileCheck option.



================
Comment at: llvm/lib/Support/FileCheckImpl.h:432
+  /// Ignore case while matching if set to true.
+  bool IgnoreCase;
+
----------------
`bool IgnoreCase = false;` and delete the member initializer below.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68146/new/

https://reviews.llvm.org/D68146