[PATCH] D68328: Fix occurrences that size and range of pointers are assumed to be the same.

[Joseph Faulls via Phabricator via llvm-commits]

Joe created this revision.
Joe added reviewers: delena, theraven, mkazantsev.
Herald added subscribers: llvm-commits, haicheng, hiraditya, eraman.
Herald added a project: LLVM.
Joe retitled this revision from "Fix occurances that size and range of pointers are assumed to be the same." to "Fix occurrences that size and range of pointers are assumed to be the same.".

GEP index size can be specified in the DataLayout, introduced in D42123 <https://reviews.llvm.org/D42123>. However, there were still places in which getIndexSizeInBits was used interchangeably with getPointerSizeInBits. This notably caused issues with Instcombine's visitPtrToInt; but the unit tests was incorrect, so this remained undiscovered.


Repository:
  rL LLVM

https://reviews.llvm.org/D68328

Files:
  llvm/include/llvm/Analysis/PtrUseVisitor.h
  llvm/include/llvm/Analysis/Utils/Local.h
  llvm/lib/Analysis/ConstantFolding.cpp
  llvm/lib/Analysis/InlineCost.cpp
  llvm/lib/Analysis/InstructionSimplify.cpp
  llvm/lib/Analysis/Loads.cpp
  llvm/lib/Analysis/MemoryBuiltins.cpp
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/lib/Analysis/ScalarEvolutionExpander.cpp
  llvm/lib/Analysis/ValueTracking.cpp
  llvm/lib/IR/DataLayout.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/Transforms/InstCombine/icmp-custom-dl.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68328.222793.patch
Type: text/x-patch
Size: 18926 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191002/d721952a/attachment.bin>