[PATCH] D68318: Fix: Actually erase remove the elements from AssumeHandles

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya created this revision.
hiraditya added a reviewer: sdmitriev.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68318

Files:
  llvm/lib/Analysis/AssumptionCache.cpp


Index: llvm/lib/Analysis/AssumptionCache.cpp
===================================================================
--- llvm/lib/Analysis/AssumptionCache.cpp
+++ llvm/lib/Analysis/AssumptionCache.cpp
@@ -130,7 +130,9 @@
     if (AVI != AffectedValues.end())
       AffectedValues.erase(AVI);
   }
-  remove_if(AssumeHandles, [CI](WeakTrackingVH &VH) { return CI == VH; });
+  AssumeHandles.erase(remove_if(AssumeHandles,
+                                [CI](WeakTrackingVH &VH) { return CI == VH; }),
+                      AssumeHandles.end());
 }
 
 void AssumptionCache::AffectedValueCallbackVH::deleted() {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68318.222752.patch
Type: text/x-patch
Size: 609 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191002/ad7b0bb1/attachment.bin>