[PATCH] D66280: [llvm-objcopy][MachO] Support indirect symbol table

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 14:18:37 PDT 2019


alexshap added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/MachO/Object.h:116
+struct IndirectSymbolEntry {
+  uint32_t OriginalIndex;
+  /// The Symbol referenced by this entry. It's None if the index is
----------------
I'd extend this comment a little bit by saying that the higher bits of this Index encode that extra information (if it is INDIRECT_SYMBOL_LOCAL or INDIRECT_SYMBOL_ABS), so that there is this extra hidden structure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66280/new/

https://reviews.llvm.org/D66280





More information about the llvm-commits mailing list