[PATCH] D67989: [ValueTracking] Improve pointer offset computation for cases of same base

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 10:57:55 PDT 2019


eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

I think this can be easily generalized even more to handle the case when both Ptr1 and Ptr2 are GEPs of some common base - replace getOffsetFromBase with getOffsetAndBase, check that the bases are the same, return the difference between offsets.

But this is fine at it is, LGTM.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67989/new/

https://reviews.llvm.org/D67989





More information about the llvm-commits mailing list