[PATCH] D68101: [MC][ELF] Prevent globals with an explicit section from being mergeable

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 10:20:51 PDT 2019


bd1976llvm added a subscriber: mcgrathr.
bd1976llvm added a comment.

In D68101#1689622 <https://reviews.llvm.org/D68101#1689622>, @SjoerdMeijer wrote:

> Hi Ben, this is not really my area of expertise, but it all starts to make some sense to me. I was expecting this transformation to happen earlier, but this is where the magic happens, and this probably where it belongs.
>  Just to make sure I haven't missed anything, I would like to take this patch and run some numbers, for which I need a little bit of time. If in the mean time someone with some more experience in this area here has a look too, that would be great....


Thanks. I am not sure who can review this. I added people form the "#pragma clang section" reviews. I will add @mcgrathr as this is a frontend interacting with linking issue.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68101/new/

https://reviews.llvm.org/D68101





More information about the llvm-commits mailing list