[PATCH] D68265: [InstCombine] Simplify fma multiplication to nan for undef or nan operands.

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 1 08:56:03 PDT 2019


cameron.mcinally accepted this revision.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4612
   if (FMF.noNaNs() && FMF.noSignedZeros() && match(Op0, m_AnyZeroFP()))
     return ConstantFP::getNullValue(Op1->getType());
 
----------------
Side note: these 2 transforms are not correct for X=Inf. I believe that they should return a QNaN in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68265/new/

https://reviews.llvm.org/D68265





More information about the llvm-commits mailing list