[PATCH] D67649: [FileCheck] Move private interface to its own header

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.

LGTM with 2 minor nits.



================
Comment at: llvm/lib/Support/FileCheck.cpp:17
 #include "llvm/Support/FileCheck.h"
+#include "FileCheckImpl.h"
 #include "llvm/ADT/StringSet.h"
----------------
I'd reorder to either place `FileCheckImpl.h` before or after `llvm/*` includes group for consistency.
I believe this is a more common way in LLVM.


================
Comment at: llvm/lib/Support/FileCheckImpl.h:1
-//==-- llvm/Support/FileCheck.h ---------------------------*- C++ -*-==//
+//===-- FileCheck.h - Private FileCheck Interface ----------------*- C++ -*-==//
 //
----------------
FileCheck.h -> FileCheckImpl.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67649/new/

https://reviews.llvm.org/D67649