[PATCH] D68218: [WebAssembly] Unstackify regs after fixing unwinding mismatches

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 15:47:39 PDT 2019


dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp:699
+// have their uses in Split.
+static void unstackifyVRegsInSplitBB(MachineBasicBlock &MBB,
+                                     MachineBasicBlock &Split) {
----------------
It might be more convenient/concise to just pass in `MRI`/`MFI` from the caller. (Hopefully the resulting code would be the same, but I guess in an unoptimized build, maybe faster too).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68218/new/

https://reviews.llvm.org/D68218





More information about the llvm-commits mailing list