[PATCH] D68234: [LegacyPassManager] Deprecate the BasicBlockPass/Manager.

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: include/llvm/Pass.h:309-311
+/// Deprecated - do not create new passes as BasicBlockPasses. Use FunctionPass
+/// with a loop over the BasicBlocks instead.
+//
----------------
asbirlea wrote:
> tra wrote:
> > Would it make sense to add an `__attribute__((__deprected__...))` to relevant functions?
> > 
> I tried to add the attribute to the class, but there are still the Printer passes which I can only remove, not update. So I resigned myself to only add a comment in this cleanup and have another one later to delete unnecessary code.
SGTM.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68234/new/

https://reviews.llvm.org/D68234