[PATCH] D68197: AMDGPU/GlobalISel: Legalize G_GLOBAL_VALUE

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle accepted this revision.
nhaehnle added a comment.
This revision is now accepted and ready to land.

LGTM, with two nitpicks.



================
Comment at: lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:1517-1518
+  unsigned Offset, unsigned GAFlags) const {
+  // In order to support pc-relative addressing, the PC_ADD_REL_OFFSET SDNode is
+  // lowered to the following code sequence:
+  //
----------------
There is no SDNode here... maybe: "global values are lowered".


================
Comment at: lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:1549-1550
+  LLT ConstPtrTy = LLT::pointer(AMDGPUAS::CONSTANT_ADDRESS, 64);
+
+
+  Register PCReg = PtrTy.getSizeInBits() != 32 ? DstReg :
----------------
Remove one empty line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68197/new/

https://reviews.llvm.org/D68197