[PATCH] D68007: [lldb] Move swig call from python code to cmake

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 09:34:33 PDT 2019


JDevlieghere added inline comments.


================
Comment at: lldb/trunk/scripts/CMakeLists.txt:5
+  ${LLDB_SOURCE_DIR}/include/lldb/API/*.h
+  ${LLDB_SOURCE_DIR}/include/lldb/*.h
 )
----------------
xiaobai wrote:
> hhb wrote:
> > xiaobai wrote:
> > > Doesn't this now include the `lldb-private` headers now? Is that intended?
> > Oh sorry. Will send a change to fix. Is there an easy way to exclude a pattern in file() call?
> You can use `EXCLUDE` but I'm not sure that works with `file(GLOB)`. It might be better just to enumerate all the headers you want to use instead of globbing.
+1


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68007/new/

https://reviews.llvm.org/D68007





More information about the llvm-commits mailing list