[PATCH] D68201: [Alignment][NFC] Adding a max function.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 02:23:41 PDT 2019


courbet accepted this revision.
courbet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/unittests/Support/AlignmentTest.cpp:241
+  EXPECT_EQ(max(MaybeAlign(4), Align(2)), Align(4));
+  EXPECT_EQ(max(Align(2), MaybeAlign(4)), Align(4));
+}
----------------
Maybe add tests for `max(Align, Align)` to make sure ADL resolves as expected.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68201/new/

https://reviews.llvm.org/D68201





More information about the llvm-commits mailing list