[PATCH] D68145: [AMDGPU] Make printf lowering faster when there are no printfs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 10:21:30 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:574-575
+
+  for (auto &U : PrintfFunction->uses())
+    if (auto *CI = dyn_cast<CallInst>(U.getUser()))
+      if (CI->isCallee(&U))
----------------
Braces


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPrintfRuntimeBinding.cpp:575
+  for (auto &U : PrintfFunction->uses())
+    if (auto *CI = dyn_cast<CallInst>(U.getUser()))
+      if (CI->isCallee(&U))
----------------
Perhaps CallSiteBase in cases printf ever ends up invoked maybe?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68145/new/

https://reviews.llvm.org/D68145





More information about the llvm-commits mailing list