[PATCH] D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 10:11:03 PDT 2019

Previous message: [PATCH] D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins.
Next message: [PATCH] D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

davidxl added a comment.

This generally looks good, but I suggest changing the name of ValueProfileOracle to ValueProfileCollector to make it explicit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67920/new/

https://reviews.llvm.org/D67920

Previous message: [PATCH] D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins.
Next message: [PATCH] D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list