[PATCH] D66991: [PowerPC] Fix SH field overflow issue

Yi-Hong Lyu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 10:11:03 PDT 2019


Yi-Hong.Lyu marked 2 inline comments as done.
Yi-Hong.Lyu added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/sh-overflow.mir:50
+frameInfo:
+  maxAlignment:    1
+machineFunctionInfo: {}
----------------
jsji wrote:
> nit: `alignment` and `maxAlignment` seems random here, any reason you want to use 1 here?
The special_right_shift32_0 is derived from
```
unsigned int test(unsigned int a, unsigned int b) {
  return a >> b;
}
```
generated by `clang --target=powerpc-unknown-unknown`. In contrast, the special_right_shift64_0 is  derived from
```
unsigned long test(unsigned long a, unsigned long b) {
  return a >> b;
}
```
generated by `clang --target=powerpc64-unknown-unknown`. I just leave `alignment` and `maxAlignment` as it is. What alignment and maxAlignment  do you think it should be?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66991/new/

https://reviews.llvm.org/D66991





More information about the llvm-commits mailing list