[PATCH] D68047: [SampleFDO] Create a separate flag ProfileAccurateForProfSymList for handling profile symbol list

[Wei Mi via Phabricator via llvm-commits]

wmi marked 2 inline comments as done.
wmi added inline comments.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:1674
 
-  if (ProfileSampleAccurate) {
+  if (ProfileAccurateForSymsInList) {
     NamesInProfile.clear();
----------------
davidxl wrote:
> check PSL too?
Fixed.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:1782
+  // about new and hot functions being mistakenly treated as cold.
+  if (ProfileAccurateForSymsInList && PSL) {
+    // Initialize the entry count to 0 for functions in the list.
----------------
davidxl wrote:
> If symbol list is available, it will override the decision of -fprofile-sample-accurate. Is this the intended behavior?
Good point. I feel it is safer to keep the profile-sample-accurate behavior the same especially if large scale rollout of PSL is needed, so I will change it. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68047/new/

https://reviews.llvm.org/D68047