[PATCH] D68123: [CodeGen][SelectionDAG] Fix tiny bug in ExpandIntRes_UADDSUBO

Itay Bookstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 05:38:13 PDT 2019


ibookstein added a comment.

As this would only affect a hypothetical target that supports ISD::SUBCARRY but not ISD::ADDCARRY, testing this via IR would seem overkill.
I think the correct level of testing for this would be UT for DAGTypeLegalizer, but the closest thing I could find was some of the things under llvm/unittests/CodeGen, like AArch64SelectionDAGTest.cpp.
Does that sound like it's in the right direction?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68123/new/

https://reviews.llvm.org/D68123





More information about the llvm-commits mailing list