[PATCH] D67948: [LV] Interleaving should not exceed estimated loop trip count.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

This looks reasonable to me, but I'm not a qualified reviewer in this area.



================
Comment at: llvm/test/Transforms/LoopVectorize/interleave_short_tc.ll:1
+; Check that we won't interleave by more than "best known" estimated trip count.
+
----------------
I would suggest using an autogenerate checks for these.  It'll be more verbose, but also more clear about the expected output.

See utils/update_test_checks.py and FileCheck's --check-prefix option for the three variations.


================
Comment at: llvm/test/Transforms/LoopVectorize/interleave_short_tc.ll:65
+
+attributes #0 = { nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="none" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { argmemonly nounwind willreturn }
----------------
Please remove unnecessary aspects of test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67948/new/

https://reviews.llvm.org/D67948