[PATCH] D68067: [libFuzzer] Dump trace and provide correct msg for overwritten input.

[Mitch Phillips via Phabricator via llvm-commits]

hctim marked 2 inline comments as done.
hctim added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerLoop.cpp:518
          GetPid());
+  PrintStackTrace();
+  Printf("SUMMARY: libFuzzer: overwrites-const-input\n");
----------------
morehouse wrote:
> I don't see a benefit to printing this stack trace -- it will always be in libFuzzer code.
>From @Dor1s above - it may be nice to have just for consistency's sake.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerLoop.cpp:521
   DumpCurrentUnit("crash-");
-  Printf("SUMMARY: libFuzzer: out-of-memory\n");
+  PrintFinalStats();
   _Exit(Options.ErrorExitCode); // Stop right now.
----------------
morehouse wrote:
> Also not sure if stats are actually valuable.  Overwriting the input means there's a bug in the fuzz target, probably not the library being fuzzed.
Not necessarily, they could `const_cast` away deep in a library and mangle the data down there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68067/new/

https://reviews.llvm.org/D68067