[PATCH] D68081: Allow update_test_checks.py to not scrub names

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 11:17:12 PDT 2019


greened added a comment.

In D68081#1684028 <https://reviews.llvm.org/D68081#1684028>, @lebedev.ri wrote:

> I'm not sure this is a good idea.


Can you explain a bit more?  The use-case is testing a transformation that simply updates an instruction, such as adding metadata.  The assumption is that the generated test will be edited for brevity (as the script comments indicate) and that the user knows that names could change.  Many times such tests will never change names because they are trivial, only running a single pass that doesn't add or delete any Values.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68081/new/

https://reviews.llvm.org/D68081





More information about the llvm-commits mailing list