[PATCH] D68054: Regex: Add static convenience functions for "match" and "sub"

Nicolas Guillemot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 10:15:03 PDT 2019


nlguillemot marked 3 inline comments as done.
nlguillemot added inline comments.


================
Comment at: include/llvm/Support/Regex.h:90-92
+    /// Assuming no regex compilation errors, equivalent to the following:
+    ///
+    ///   Regex(RegexPattern, Flags, Error).match(String, Matches, Error)
----------------
thopre wrote:
> While redundant, I'd add "which returns an error if the regex is invalid or no match is found" to be more explicit
I expanded the description. Thoughts?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68054/new/

https://reviews.llvm.org/D68054





More information about the llvm-commits mailing list