[PATCH] D67525: [WIP] Add WASM_TABLE_INDEX_{SLEB,I32} reloc types with addends

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 10:15:02 PDT 2019


sbc100 added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp:153
-    if (WasmSym->isFunction())
-      report_fatal_error("Function addresses with offsets not supported");
     if (WasmSym->isGlobal())
----------------
Can you link the bug where we discuessed this.  I'm having trouble remember why should even allow this give that it doesn't make any sense to do arithmetic on table indexes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67525/new/

https://reviews.llvm.org/D67525





More information about the llvm-commits mailing list