[PATCH] D67841: [SLP] avoid reduction transform on patterns that the backend can load-combine

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 09:04:21 PDT 2019


spatel marked 2 inline comments as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6497
+      if (ReductionData.getOpcode() == Instruction::Or)
+        LoadCombineCost = TTI->getLoadCombineCost(FirstReducedVal);
+      if (LoadCombineCost) {
----------------
ABataev wrote:
> Shall we move all this stuff to `TargetTransformInfo::getArithmeticInstrCost`?
Do you have a specific suggestion about how to alter that API to make this fit? 

I'm not seeing how to do it without making this more confusing than having a dedicated function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67841/new/

https://reviews.llvm.org/D67841





More information about the llvm-commits mailing list