[PATCH] D68057: [mips] Relax jalr/jr instructions using R_MIPS_JALR relocation

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 22:29:27 PDT 2019


atanasyan marked an inline comment as done.
atanasyan added inline comments.


================
Comment at: lld/ELF/Arch/Mips.cpp:645
+    // offset fits into the 18-bit range.
+    if ((int64_t)val == llvm::SignExtend64(val, 18)) {
+      switch (read32<e>(loc)) {
----------------
jrtc27 wrote:
> `isInt<18>(val)`?
Sure. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68057/new/

https://reviews.llvm.org/D68057





More information about the llvm-commits mailing list