[PATCH] D68050: WIP Make attribute target work better with AArch64

[Erich Keane via Phabricator via llvm-commits]

erichkeane created this revision.
erichkeane added reviewers: nickdesaulniers, fhahn.
Herald added subscribers: llvm-commits, dexonsmith, hiraditya, kristof.beyls.
Herald added a project: LLVM.

This bug report: https://bugs.llvm.org/show_bug.cgi?id=43448

Highlights 2 issues with the attribute target AArch64 support.

The first is that the cpu check needs to check the arch rather than
the CPU.

The second is that the AArch64 implementation of GCC's target supports
+<FEATURE> for these targets.

This patch adds these two.

However, passing the AArch64 architecture names in target-cpu
isn't supported by LLVM:

('armv8-a' is not a recognized processor for this target (ignoring processor))

This likely needs to be fixed before this patch can go in.

Note that this is necessary for the ClangBuiltLinux effort.


https://reviews.llvm.org/D68050

Files:
  clang/include/clang/Basic/Attr.td
  clang/include/clang/Basic/TargetInfo.h
  clang/lib/Basic/Targets/AArch64.cpp
  clang/lib/Basic/Targets/AArch64.h
  clang/lib/CodeGen/CodeGenModule.cpp
  clang/lib/Sema/SemaDecl.cpp
  clang/lib/Sema/SemaDeclAttr.cpp
  clang/test/CodeGen/aarch64-target-attr.c
  llvm/include/llvm/ADT/StringRef.h
  llvm/lib/Support/StringRef.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68050.221831.patch
Type: text/x-patch
Size: 13075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190925/11455f7a/attachment.bin>