[PATCH] D67998: [llvm-readobj/llvm-readelf]: Dump stack-size entry for all function symbols that have a particular value (fixes PR43245)

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added a comment.

In D67998#1682076 <https://reviews.llvm.org/D67998#1682076>, @jhenderson wrote:

> One issue that just occurred to me, is what happens if you still have the stack size entry in this case? Something like:


<snip>

> I think this is undesirable. Perhaps you need to track whether a stack size entry for a given address has been printed yet, and skip it if it has?

Yes, good observation. There is also the question what to do if the sizes of 2 different entries with the same address don't match. This should probably elicit a warning.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67998/new/

https://reviews.llvm.org/D67998