[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 09:31:25 PDT 2019


uweigand added a comment.

Otherwise this looks good to me, but it might be better to get approval from a front-end expert as well.



================
Comment at: lib/CodeGen/CodeGenFunction.cpp:899
+          CGM.getDiags().Report(diag::err_opt_not_valid_with_opt)
+            << "-mnop-mcount" << "-pg without -mfentry";
+        Fn->addFnAttr("mnop-mcount", "true");
----------------
Why not use diag::err_opt_not_valid_without_opt here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67763/new/

https://reviews.llvm.org/D67763





More information about the llvm-commits mailing list