[PATCH] D67759: [llvm-readobj] - Simplify stack-sizes.test test case.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 05:15:08 PDT 2019


grimar updated this revision to Diff 221726.
grimar retitled this revision from "[llvm-readobj] - Support uniqued ".stack_sizes" and simplify stack-sizes.test test case." to "[llvm-readobj] - Simplify stack-sizes.test test case.".
grimar edited the summary of this revision.
grimar added a comment.

- Rebased after D68018 <https://reviews.llvm.org/D68018>.

Now all code changes are gone and patch is in the same state as it was accepted.
Going to commit it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67759/new/

https://reviews.llvm.org/D67759

Files:
  test/tools/llvm-readobj/stack-sizes.test


Index: test/tools/llvm-readobj/stack-sizes.test
===================================================================
--- test/tools/llvm-readobj/stack-sizes.test
+++ test/tools/llvm-readobj/stack-sizes.test
@@ -44,14 +44,15 @@
     Size:    16
   - Name:    .stack_sizes
     Type:    SHT_PROGBITS
-## 2 stack size entries. Each consists of an address (subject to relocation)
-## followed by a ULEB for the size.
-    Content: "000000000000000010000000000000000020"
+    Entries:
+      - Size: 0x10
+      - Size: 0x20
     Link:    .text
   - Name:    '.stack_sizes [1]'
     Type:    SHT_PROGBITS
-## One stack size entry.
-    Content: "200000000000000008"
+    Entries:
+      - Address: 0x20
+        Size:    0x8
     Link:    .text.baz
   - Name:    .rela.stack_sizes
     Type:    SHT_RELA
@@ -127,7 +128,11 @@
     Size:    16
   - Name:    .stack_sizes
     Type:    SHT_PROGBITS
-    Content: "100000000000000010200000000000000020"
+    Entries:
+      - Address: 0x10
+        Size:    0x10
+      - Address: 0x20
+        Size:    0x20
     Link:    .text
 Symbols:
   - Name:    foo
@@ -215,7 +220,8 @@
     Flags:   [SHF_ALLOC]
   - Name:    .stack_sizes
     Type:    SHT_PROGBITS
-    Content: "000000000000000008"
+    Entries:
+      - Size: 0x8
     Link:    .text2
   - Name:    .rela.stack_sizes
     Type:    SHT_RELA
@@ -328,7 +334,8 @@
   - Name:    .stack_sizes
     Type:    SHT_PROGBITS
     Link:    .text
-    Content: "000000000000000008"
+    Entries:
+      - Size: 0x8
   - Name:    .rela.stack_sizes
     Type:    SHT_RELA
     Info:    .stack_sizes
@@ -373,7 +380,8 @@
   - Name:    .stack_sizes
     Type:    SHT_PROGBITS
     Link:    .text
-    Content: "000000000000000008"
+    Entries:
+      - Size: 0x1
 
 ## Check that we handle multiple object files, separately and when they
 ## are in an archive. This also checks whether we have blank lines between the
@@ -589,7 +597,9 @@
     Size:    16
   - Name:    .stack_sizes
     Type:    SHT_PROGBITS
-    Content: "100000000000000010"
+    Entries:
+      - Address: 0x10
+        Size:    0x10
     Link:    .text
 Symbols:
   - Name:    _Z3foof


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67759.221726.patch
Type: text/x-patch
Size: 2140 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190925/7a5d69ce/attachment.bin>


More information about the llvm-commits mailing list