[PATCH] D68012: [llvm-readobj/llvm-readelf] - .stack_sizes: demangle symbol names in warnings reported.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:4786
           createError("cannot identify the section for relocation symbol " +
-                      SymName),
+                      getSymbolName(*RelocSym)),
           FileStr);
----------------
Since we're now demangling these symbols, I wonder if it would make sense here and in the other warning to quote the symbol names, because demangled names can be phrases rather than individual names. Quoting would make the name easier to read, I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68012/new/

https://reviews.llvm.org/D68012