[PATCH] D67962: [llvm-readobj] - Don't crash when dumping .stack_sizes and unable to find a relocation resolver.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

I'm beginning to think that stack-sizes.test needs breaking up into smaller tests...! This change LGTM anyway.



================
Comment at: test/tools/llvm-readobj/stack-sizes.test:600
+
+## Check that we report an error when we unable to resolve a relocation for a given ELF arch.
+## Here we have a valid 64-bit relocation used in a 32-bit object.
----------------
when we unable -> when we are unable

I'd also probably avoid unnecessarily abbreviating architecture to arch.


================
Comment at: test/tools/llvm-readobj/stack-sizes.test:601
+## Check that we report an error when we unable to resolve a relocation for a given ELF arch.
+## Here we have a valid 64-bit relocation used in a 32-bit object.
+
----------------
I'd probably just get rid of "valid" since a 64-bit relocation in a 32-bit object doesn't really make sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67962/new/

https://reviews.llvm.org/D67962