[PATCH] D67957: [ARM] Cortex-M4 schedule additions

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 01:55:28 PDT 2019


dmgreen added a comment.

Thanks for taking a look.

I believe that those instructions would only be generated on windows targets from ISelLowering, from functions like LowerDYNAMIC_STACKALLOC. As in, they require IsWindows anyway by the fact that they will not be generated anywhere else, we are just teaching ISel the same thing!

But looking again I think it's simpler to make that hasNoSchedulingInfo as it usesCustomInserter anyway, and the scheduler will not see it in the normal scheduler. They get expanded post-isel into a BL call to __chkstk and a sub.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67957/new/

https://reviews.llvm.org/D67957





More information about the llvm-commits mailing list