[PATCH] D67998: [llvm-readobj/llvm-readelf]: Dump stack-size entry for all function symbols that have a particular value (fixes PR43245)

[James Henderson via Phabricator via llvm-commits]

jhenderson added a reviewer: MaskRay.
jhenderson added inline comments.


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:4728-4730
+    reportWarning(
+        createError("could not identify function symbol for stack size entry"),
+        Obj->getFileName());
----------------
I think it would be good if we could avoid duplicating this `reportWarning` call (especially the text part). Perhaps worth a small lambda, or at least pulling the message into a `StringRef`?


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:4731
+        Obj->getFileName());
+    printStackSizeEntry(StackSize, "?");
+  }
----------------
Whilst not strictly necessary, it might be good to `return` here. I think that would be less likely to run into surprises due to future code changes below it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67998/new/

https://reviews.llvm.org/D67998