[PATCH] D67995: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 16:06:50 PDT 2019


asbirlea created this revision.
asbirlea added a reviewer: george.burgess.iv.
Herald added subscribers: sanjoy.google, Prazek.
Herald added a project: LLVM.

If a block has all incoming values with the same MemoryAccess (ignoring
incoming values from unreachable blocks), then use that incoming
MemoryAccess and do not create a Phi in the first place.

Revert IDF work-around added in rL372673 <https://reviews.llvm.org/rL372673>; it should not be required unless
the Def inserted is the first in its block.

The patch also cleans up a series of tests, added during the many
iterations on insertDef.


Repository:
  rL LLVM

https://reviews.llvm.org/D67995

Files:
  lib/Analysis/MemorySSAUpdater.cpp
  test/Analysis/MemorySSA/PR42940.ll
  test/Analysis/MemorySSA/PR43044.ll
  test/Analysis/MemorySSA/pr40754.ll
  test/Analysis/MemorySSA/pr41640.ll
  test/Analysis/MemorySSA/pr42940.ll
  test/Analysis/MemorySSA/pr43044.ll
  test/Analysis/MemorySSA/pr43317.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67995.221617.patch
Type: text/x-patch
Size: 18527 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190924/f6041495/attachment.bin>


More information about the llvm-commits mailing list