[PATCH] D67956: [ARM] Lower MVE i1 inserts through shifts, not inreg extend

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 12:49:57 PDT 2019


efriedma added a comment.

If SelectionDAGLegalize::ExpandNode is expanding SIGN_EXTEND_INREG of i1 to a non-canonical form, maybe it makes more sense to fix that, instead of trying to avoid that codepath?  I mean, this is fine, given we know it's going to get expanded anyway.  But the same problem might come up again later out of target-independent code generating an i1 SIGN_EXTEND_INREG.

But we can merge this now and deal with that later, if you want.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67956/new/

https://reviews.llvm.org/D67956





More information about the llvm-commits mailing list