[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 08:51:55 PDT 2019


rnk added subscribers: davide, filcab.
rnk added a comment.

The main alternative worth mentioning is `_exit`, which LLD already uses for the same reason you mention here.

Honestly, I think there is consensus that calling `abort` here is the right thing and we should just do it. It's not like LLVM is already fuzzer clean, and if this does reopen fuzzer bugs, it's good to fix them properly anyway. :)

I mostly wanted to link back to the past attempt to do this to get the reviewers involved in that to +1 this new attempt. I guess I'll @ some more: @davide, @filcab, @mehdi_amini


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67847/new/

https://reviews.llvm.org/D67847





More information about the llvm-commits mailing list