[PATCH] D67753: [gn build] Fix Python DeprecationWarning

Tue Sep 24 08:10:36 PDT 2019

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

> Apparently I was slightly wrong: it's not specific to the .4 maintenance release but any 3.7 version. On the download page <https://www.python.org/downloads/release/python-374/> I though the items applied to 3.7.4 only, but as can be confirmed by the 3.7 documentation page <https://docs.python.org/3/whatsnew/3.7.html> it's not. Apologies for this. The fix is still relevant though.
> 
> I assume you couldn't reproduce the warnings. Do you have by any change some PYTHONWARNINGS <https://docs.python.org/3/using/cmdline.html#envvar-PYTHONWARNINGS> environment variable turning the warning off or some command line argument that does the same?

Aha, thanks, if I run `PYTHONWARNINGS=default ninja -C out/gn -j200 check-clang` I see the warnings. But by default they're not on for me, and I don't have PYTHONWARNINGS set. Do you set it to anything? Does anything else set it in your env?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67753/new/

https://reviews.llvm.org/D67753