[PATCH] D47927: [TargetLowering] Simplify expansion of S{ADD,SUB}O

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 23:21:01 PDT 2019


rogfer01 added a comment.

In D47927#1652507 <https://reviews.llvm.org/D47927#1652507>, @nikic wrote:

> IMHO this should land as-is, and setcc folds can be implemented additionally if there are other places where they would be useful. My rationale would be that it is better to directly perform a simpler lowering than a complex lowering that then gets optimized. (Basically: If you can reduce the size of the implementing code //and// get a better result, then I think we should always be doing that.)


Hi @nikic, thanks for your comments. It also makes sense to me to do this.

If there aren't any further comments I pland to land this in the next days.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D47927/new/

https://reviews.llvm.org/D47927





More information about the llvm-commits mailing list