[PATCH] D67301: [LLD] Use the unified llvm demangle frontend function. NFC.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 05:35:39 PDT 2019


ruiu added inline comments.


================
Comment at: lld/COFF/Symbols.cpp:39-40
+    std::string demangled = demangle(demangleInput, /*strictPrefix=*/true);
+    if (demangled != demangleInput)
+      return prefix + demangled;
   }
----------------
Does this mean `__imp_foo` is printed as just `__imp_foo` but any C++ mangled name after `__imp_` is printed as `__declspec(dllimport) ...`? It feels to me that always "demangle" __imp prefix is more consistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67301/new/

https://reviews.llvm.org/D67301





More information about the llvm-commits mailing list