[PATCH] D67241: Regex: Make "match" and "sub" const member functions

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added a comment.

In D67241#1679937 <https://reviews.llvm.org/D67241#1679937>, @nlguillemot wrote:

> In D67241#1679847 <https://reviews.llvm.org/D67241#1679847>, @thopre wrote:
>
> > In D67241#1679348 <https://reviews.llvm.org/D67241#1679348>, @nlguillemot wrote:
> >
> > > friendly reminder ping
> >
> >
> > My bad, I misunderstood you and thought you'd do a patch to  implement the "Create a Regex and immediately throw it away" idiom and rebase that one on top of it.
>
>
> I could do that. By "rebase that one on top of it", do you mean to include the additional changes in this same review?


I meant make a patch series/stack where the first one adds the new idiom and the second is this one where the matching only checks for matching errors. But it's ok to do it the other way around, I'll commit this now once I've finished a build+check-all and you can add the changes for the new idiom on top of it.

Best regards.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67241/new/

https://reviews.llvm.org/D67241