[PATCH] D67032: [ELF] Align SHT_LLVM_PART_EHDR to a maximum page size boundary

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 20:01:42 PDT 2019


MaskRay added a comment.

In D67032#1679680 <https://reviews.llvm.org/D67032#1679680>, @pcc wrote:

> Alternatively it looks like we could increase the alignment of the partition ELF header section here: http://llvm-cs.pcc.me.uk/tools/lld/ELF/SyntheticSections.cpp#3581


This approach will need a bit more work not to overadvance dot (we advance to the `addrExpr()` aligned address, then `alignment` aligned address):

  [17] .data             PROGBITS        0000000000003178 002178 000008 00  WA  0   0  1                        
  [18] .got.plt          PROGBITS        0000000000003180 002180 000028 00  WA  0   0  8                        
  [19] part1             LOOS+0xfff4c06  0000000000005000 003000 000040 00   A  0   0 4096 <------- 0x5000 can be 0x4000

But I'll check if this can be implemented.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67032/new/

https://reviews.llvm.org/D67032





More information about the llvm-commits mailing list