[PATCH] D67845: SSP: [3/3] cmpxchg and addrspacecast can now trigger stack protection

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 08:49:55 PDT 2019


probinson updated this revision to Diff 221347.
probinson added a comment.

HasAddressTaken now defaults to true; this means explicitly handling innocuous instructions.

- load does not store anything.
- atomicrmw cannot store a pointer unless it goes through ptrtoint, which we handle explicitly.
- ret is irrelevant because the current frame goes away after the ret.

Update test to verify those instructions do not trigger a stack protector.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67845/new/

https://reviews.llvm.org/D67845

Files:
  llvm/lib/CodeGen/StackProtector.cpp
  llvm/test/CodeGen/X86/stack-protector-2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67845.221347.patch
Type: text/x-patch
Size: 9910 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190923/c63d37d0/attachment.bin>


More information about the llvm-commits mailing list