[PATCH] D66724: [AIX]Emit function descriptor csect in assembly

Jason Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 08:01:42 PDT 2019


jasonliu accepted this revision.
jasonliu added a comment.

LGTM with some minor change.

Should SupportsQuotedNames return false on AIX?



================
Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:29
+bool MCAsmInfoXCOFF::isValidUnquotedName(StringRef Name) const {
+  // FIXME: remove this function when we don't use " TOC[TC0]" as symbol name
+  // any more.
----------------
nit: remove space in " TOC[TC0]".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66724/new/

https://reviews.llvm.org/D66724





More information about the llvm-commits mailing list