[PATCH] D67817: [LNT] Python 3 support: adapt to map returning a view

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 23 07:46:53 PDT 2019


hubert.reinterpretcast added inline comments.


================
Comment at: lnt/external/stats/stats.py:1575
         alldata = alldata + lists[i]
     alldata = N.array(alldata)
     bign = len(alldata)
----------------
hubert.reinterpretcast wrote:
> Drive by:
> `alldata = N.array(list(itertools.chain.from_iterable(lists)))`
Hmm, since we need a list anyway, maybe:
```
for list in lists:
    alldata.extend(list)
```

I don't know enough about the way the implementation works to know that the `chain` version would be handled as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67817/new/

https://reviews.llvm.org/D67817





More information about the llvm-commits mailing list