[PATCH] D67828: [ARM] Split large truncating MVE stores

[Dave Green via Phabricator via llvm-commits]

dmgreen marked 2 inline comments as done.
dmgreen added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:13261
+
+    unsigned Multiple = 0;
+    if (FromEltVT == MVT::i32 && (ToEltVT == MVT::i16 || ToEltVT == MVT::i8))
----------------
samparker wrote:
> Nit: NumElements..?
Yeah, sounds a lot better.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:13271
+    SDLoc DL(St);
+    // Details about the old load
+    SDValue Ch = St->getChain();
----------------
samparker wrote:
> old load?!
Sounds like I should put up the load patch too! It's roughly similar to this, so I'll try and make the same changes there.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67828/new/

https://reviews.llvm.org/D67828