[llvm] r372489 - [NFC][InstSimplify] Add exhaustive test coverage for simplifyUnsignedRangeCheck().

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 21 15:27:18 PDT 2019


Author: lebedevri
Date: Sat Sep 21 15:27:18 2019
New Revision: 372489

URL: http://llvm.org/viewvc/llvm-project?rev=372489&view=rev
Log:
[NFC][InstSimplify] Add exhaustive test coverage for simplifyUnsignedRangeCheck().

One case is not handled.

Added:
    llvm/trunk/test/Transforms/InstSimplify/unsigned-range-checks.ll

Added: llvm/trunk/test/Transforms/InstSimplify/unsigned-range-checks.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstSimplify/unsigned-range-checks.ll?rev=372489&view=auto
==============================================================================
--- llvm/trunk/test/Transforms/InstSimplify/unsigned-range-checks.ll (added)
+++ llvm/trunk/test/Transforms/InstSimplify/unsigned-range-checks.ll Sat Sep 21 15:27:18 2019
@@ -0,0 +1,132 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt %s -instsimplify -S | FileCheck %s
+
+; Here we add unsigned two values, check that addition did not underflow AND
+; that the result is non-zero. This can be simplified just to a comparison
+; between the base and negated offset.
+
+; If we are checking that the result is not null or no underflow happened,
+; it is tautological (always-true).
+define i1 @t1(i8 %x, i8 %y) {
+; CHECK-LABEL: @t1(
+; CHECK-NEXT:    ret i1 true
+;
+  %not_null = icmp ne i8 %y, 0
+  %no_underflow = icmp ule i8 %y, %x
+  %r = or i1 %not_null, %no_underflow
+  ret i1 %r
+}
+define i1 @t2_commutative(i8 %x, i8 %y) {
+; CHECK-LABEL: @t2_commutative(
+; CHECK-NEXT:    ret i1 true
+;
+  %not_null = icmp ne i8 %y, 0
+  %no_underflow = icmp uge i8 %x, %y ; swapped
+  %r = or i1 %not_null, %no_underflow
+  ret i1 %r
+}
+
+define i1 @t3_commutative(i8 %x, i8 %y) {
+; CHECK-LABEL: @t3_commutative(
+; CHECK-NEXT:    ret i1 true
+;
+  %not_null = icmp ne i8 %y, 0
+  %no_underflow = icmp ule i8 %y, %x
+  %r = or i1 %no_underflow, %not_null ; swapped
+  ret i1 %r
+}
+define i1 @t4_commutative(i8 %x, i8 %y) {
+; CHECK-LABEL: @t4_commutative(
+; CHECK-NEXT:    ret i1 true
+;
+  %not_null = icmp ne i8 %y, 0
+  %no_underflow = icmp uge i8 %x, %y ; swapped
+  %r = or i1 %no_underflow, %not_null ; swapped
+  ret i1 %r
+}
+
+; If we are checking that the result is null and underflow happened,
+; it is tautological (always-false).
+define i1 @t5(i8 %x, i8 %y) {
+; CHECK-LABEL: @t5(
+; CHECK-NEXT:    ret i1 false
+;
+  %not_null = icmp eq i8 %y, 0
+  %no_underflow = icmp ugt i8 %y, %x
+  %r = and i1 %not_null, %no_underflow
+  ret i1 %r
+}
+define i1 @t6_commutative(i8 %x, i8 %y) {
+; CHECK-LABEL: @t6_commutative(
+; CHECK-NEXT:    ret i1 false
+;
+  %not_null = icmp eq i8 %y, 0
+  %no_underflow = icmp ult i8 %x, %y ; swapped
+  %r = and i1 %not_null, %no_underflow
+  ret i1 %r
+}
+
+; We only need to know that any of the 'add' operands is non-zero,
+; not necessarily the one used in the comparison.
+define i1 @t7(i8 %x, i8 %y) {
+; CHECK-LABEL: @t7(
+; CHECK-NEXT:    ret i1 true
+;
+  %cmp = icmp slt i8 %y, 0
+  %not_null = icmp ne i8 %y, 0
+  %no_underflow = icmp ule i8 %y, %x
+  %r = or i1 %not_null, %no_underflow
+  ret i1 %r
+}
+
+; If we check that no underflow happened and that the result is null,
+; we can just check for null.
+define i1 @t8(i8 %x, i8 %y) {
+; CHECK-LABEL: @t8(
+; CHECK-NEXT:    [[NOT_NULL:%.*]] = icmp eq i8 [[Y:%.*]], 0
+; CHECK-NEXT:    [[NO_UNDERFLOW:%.*]] = icmp ule i8 [[Y]], [[X:%.*]]
+; CHECK-NEXT:    [[R:%.*]] = and i1 [[NOT_NULL]], [[NO_UNDERFLOW]]
+; CHECK-NEXT:    ret i1 [[R]]
+;
+  %not_null = icmp eq i8 %y, 0
+  %no_underflow = icmp ule i8 %y, %x
+  %r = and i1 %not_null, %no_underflow
+  ret i1 %r
+}
+; Likewise, if we check that result is non-null or underflow happened,
+; we can just check for null.
+define i1 @t9(i8 %x, i8 %y) {
+; CHECK-LABEL: @t9(
+; CHECK-NEXT:    [[NOT_NULL:%.*]] = icmp ne i8 [[Y:%.*]], 0
+; CHECK-NEXT:    ret i1 [[NOT_NULL]]
+;
+  %not_null = icmp ne i8 %y, 0
+  %no_underflow = icmp ugt i8 %y, %x
+  %r = or i1 %not_null, %no_underflow
+  ret i1 %r
+}
+
+; If we check that no underflow happened or that the result is not null,
+; we can just check for lack of underflow.
+define i1 @t10(i8 %x, i8 %y) {
+; CHECK-LABEL: @t10(
+; CHECK-NEXT:    [[NO_UNDERFLOW:%.*]] = icmp ule i8 [[Y:%.*]], [[X:%.*]]
+; CHECK-NEXT:    ret i1 [[NO_UNDERFLOW]]
+;
+  %not_null = icmp eq i8 %y, 0
+  %no_underflow = icmp ule i8 %y, %x
+  %r = or i1 %not_null, %no_underflow
+  ret i1 %r
+}
+; Likewise, if we check that underflow happened and that the result is not null,
+; we can just check for lack of underflow.
+define i1 @t11(i8 %x, i8 %y) {
+; CHECK-LABEL: @t11(
+; CHECK-NEXT:    [[NO_UNDERFLOW:%.*]] = icmp ugt i8 [[Y:%.*]], [[X:%.*]]
+; CHECK-NEXT:    ret i1 [[NO_UNDERFLOW]]
+;
+  %not_null = icmp ne i8 %y, 0
+  %no_underflow = icmp ugt i8 %y, %x
+  %r = and i1 %not_null, %no_underflow
+  ret i1 %r
+}




More information about the llvm-commits mailing list