[PATCH] D67783: [WebAssembly] Remove unused memory instructions and patterns

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 21 07:53:39 PDT 2019


aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:83
   let isMoveImm = 1, isReMaterializable = 1,
-      Predicates = [HasSIMD128, HasUnimplementedSIMD128] in
+      Predicates = [HasUnimplementedSIMD128] in
   defm CONST_V128_#vec_t : SIMD_I<(outs V128:$dst), ops, (outs), ops,
----------------
Why do we not need `HasSIMD128` anymore? For other lines that deleted this too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67783/new/

https://reviews.llvm.org/D67783





More information about the llvm-commits mailing list