[PATCH] D67864: [CodeView] Add pragma push/pop_macro for ARM64_FPSR to enum header

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 20 14:21:13 PDT 2019


mstorsjo added a comment.

In D67864#1677495 <https://reviews.llvm.org/D67864#1677495>, @TomTan wrote:

> Thanks for catching this. Could the `#pragma push` and `#undef` be moved to the line right before `CV_REGISTER(ARM64_FPSR, 220)`.


I guess I could, but the file has a predecent for this kind of placement (for CR0) as well.

> An inline commend will also be great.

Sure, I'll add that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67864/new/

https://reviews.llvm.org/D67864





More information about the llvm-commits mailing list