[PATCH] D67850: Fix missed case of switching getConstant to getTargetConstant. Try 2.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 20 11:37:41 PDT 2019


RKSimon added reviewers: RKSimon, craig.topper.
RKSimon added a comment.

The test file doesn't look like it needs GlobalIsel - rename it llvm/test/CodeGen/X86/isel-blendi-gettargetconstant.ll



================
Comment at: llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll:1
+; RUN: llc -mtriple=x86_64-linux-gnu - < %s -o -
+
----------------
RUN: llc < %s -mtriple=x86_64-linux-gnu -mattr=sse4.2 | FileCheck %s

And then run the file through the utils/update_llc_test_checks.py script


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll:3
+
+define void @csrot_(float* %0) #0 {
+1:
----------------
Remove #0


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/isel-blendi-gettargetconstant.ll:12
+
+attributes #0 = { "target-features"="+sse4.2" }
----------------
Remove this


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67850/new/

https://reviews.llvm.org/D67850





More information about the llvm-commits mailing list