[PATCH] D67768: [DebugInfo] Add interface for pre-calculating the size of emitted DWARF

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h:336
+  SmallString<32> TmpBytes;
+  SmallVector<std::string, 8> TmpComments;
+  BufferByteStreamer TmpBS;
----------------
Since we have thousands of location list entries per file and DW_OP_entry_value is comparatively rare, should we make these heap- or tail-allocated (i.e. std::vector / unique_ptr)?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67768/new/

https://reviews.llvm.org/D67768